Merge pull request #1002 from ecomfe/fix-18194

fix(svg): duplicate id for background rect with multiple charts
ecomfe · Nov 16, 2023 · 2c11063 · 2c11063
2 parents 78f84fd + 8c6b137
commit 2c11063
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/canvas/Layer.ts b/src/canvas/Layer.ts
@@ -309,7 +309,7 @@ export default class Layer extends Eventful {
              * rect if and only if it's not painted this frame and was
              * previously painted on the canvas.
              */
-            const shouldPaint = el.shouldBePainted(viewWidth, viewHeight, true, true);
+            const shouldPaint = el && el.shouldBePainted(viewWidth, viewHeight, true, true);
             if (el && (!shouldPaint || !el.__zr) && el.__isRendered) {
                 // el was removed
                 const prevRect = el.getPrevPaintRect();

diff --git a/src/svg/Painter.ts b/src/svg/Painter.ts
@@ -382,8 +382,7 @@ function createBackgroundVNode(
                 width,
                 height,
                 x: '0',
-                y: '0',
-                id: '0'
+                y: '0'
             }
         );
         if (isGradient(backgroundColor)) {

diff --git a/test/svg-backgroundColor.html b/test/svg-backgroundColor.html
@@ -42,7 +42,7 @@
         }
     });
     zr.add(txt);
-    
+
     var linearGradient = new zrender.LinearGradient();
     linearGradient.addColorStop(0, '#a598e1');
     linearGradient.addColorStop(1, '#14c4ba');
@@ -95,7 +95,6 @@
         else {
             bg = text = 'none';
         }
-        console.log(text);
         zr.setBackgroundColor(bg);
         txt.setStyle({ text: 'SVG BackgroundColor: ' + text });
         i++;