Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rows, merger: 使用 sqlx.Rows 作为接口,并重构 merger 包 #217

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

flycash
Copy link
Contributor

@flycash flycash commented Sep 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #217 (2716109) into dev (d918cee) will decrease coverage by 2.54%.
Report is 2 commits behind head on dev.
The diff coverage is 56.76%.

@@            Coverage Diff             @@
##              dev     #217      +/-   ##
==========================================
- Coverage   85.65%   83.12%   -2.54%     
==========================================
  Files          48       50       +2     
  Lines        3653     3893     +240     
==========================================
+ Hits         3129     3236     +107     
- Misses        415      540     +125     
- Partials      109      117       +8     
Files Changed Coverage Δ
internal/rows/convert_assign.go 66.66% <ø> (ø)
sharding_select.go 60.58% <10.29%> (-13.06%) ⬇️
internal/datasource/single/db.go 55.00% <28.57%> (-16.43%) ⬇️
internal/merger/batchmerger/merger.go 87.09% <37.50%> (-7.45%) ⬇️
...l/datasource/shardingsource/sharding_datasource.go 56.52% <40.74%> (-20.41%) ⬇️
internal/datasource/cluster/cluster_db.go 60.00% <45.45%> (-21.82%) ⬇️
...nternal/merger/groupby_merger/aggregator_merger.go 81.28% <64.28%> (-2.33%) ⬇️
internal/merger/pagedmerger/merger.go 94.56% <66.66%> (-2.03%) ⬇️
internal/merger/aggregatemerger/merger.go 91.72% <68.75%> (-1.80%) ⬇️
...ernal/datasource/transaction/single_transaction.go 73.33% <73.33%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@flycash flycash merged commit 07dc416 into ecodeclub:dev Sep 5, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant