Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: ShardingSelector GetMulti 使用 merge #199

Merged
merged 5 commits into from
May 10, 2023
Merged

feature: ShardingSelector GetMulti 使用 merge #199

merged 5 commits into from
May 10, 2023

Conversation

Stone-afk
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 7, 2023 •
edited
Loading

Codecov Report

Merging #199 (c128352) into dev (08a348c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
+ Coverage   85.91%   85.93%   +0.01%     
==========================================
  Files          45       45              
  Lines        3309     3313       +4     
==========================================
+ Hits         2843     2847       +4     
  Misses        374      374              
  Partials       92       92
Impacted Files Coverage Δ
internal/merger/aggregatemerger/merger.go 93.52% <ø> (ø)
internal/merger/batchmerger/merger.go 94.54% <ø> (ø)
internal/merger/pagedmerger/merger.go 96.59% <100.00%> (ø)
internal/merger/sortmerger/merger.go 89.85% <100.00%> (ø)
internal/valuer/primitive.go 100.00% <100.00%> (ø)
internal/valuer/reflect.go 93.87% <100.00%> (ø)
internal/valuer/unsafe.go 100.00% <100.00%> (ø)
sharding_select.go 76.84% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

flycash
flycash reviewed May 8, 2023
View reviewed changes
internal/valuer/unsafe.go Outdated Show resolved Hide resolved
internal/rows/types.go Show resolved Hide resolved
sharding_select.go Outdated Show resolved Hide resolved
internal/integration/sharding_select_test.go Show resolved Hide resolved
Stone-afk
Stone-afk commented May 9, 2023
View reviewed changes
Copy link
Collaborator Author

@Stone-afk Stone-afk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark

@Stone-afk
Copy link
Collaborator Author

@flycash

@flycash flycash merged commit d75d819 into ecodeclub:dev May 10, 2023
@flycash flycash mentioned this pull request May 13, 2023
Closed
@flycash flycash linked an issue May 13, 2023 that may be closed by this pull request
分库分表：ShardingSelector GetMulti 实现 #196
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flycash flycash flycash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

分库分表：ShardingSelector GetMulti 实现
2 participants
@Stone-afk @flycash