新增了sqlx.NewNullXXX系列方法 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #227 +/- ##
==========================================
+ Coverage 95.71% 95.84% +0.12%
==========================================
Files 56 57 +1
Lines 3082 3106 +24
==========================================
+ Hits 2950 2977 +27
+ Misses 101 99 -2
+ Partials 31 30 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
修复一下下方的lint错误, 并提供单元测试 |
|
收到 |
补充了license的内容；
longyue0521
requested changes
Oct 9, 2023
sqlx/newnull_test.go
Outdated
Comment on lines
25
to
31
| type args struct { | ||
| val bool | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| want sql.NullBool |
There was a problem hiding this comment.
把args结构体中的val内容平铺在tests := []struct {...},并去掉args结构体
检查下方所有测试,使其满足上述要求
sqlx/newnull_test.go
Outdated
| want sql.NullBool | ||
| }{ | ||
| { | ||
| name: "test", |
There was a problem hiding this comment.
命名不准确,还有重复,应该描述测试场景
检查下方所有测试,使其满足上述要求
|
学会查看lint提示, 点击下方 "Format Go code" 末尾的Details查看详细的报错信息并修复问题 |
longyue0521
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#222