Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重构: syncx: map #198

Merged
merged 3 commits into from
Jul 14, 2023
Merged

重构: syncx: map #198

merged 3 commits into from
Jul 14, 2023

Conversation

longyue0521
Copy link
Collaborator

@longyue0521 longyue0521 commented Jul 13, 2023

  • LoadOrStoreFunc直接调用map自身的LoadOrStore,消除重复
  • 使用子测试增力测试,某些断言使用Same方法替代Equal明确意图——map中放入与取出的指针类型应该指向同一个内存对象/内存地址,而不是不同地址内存对象但内容相同

Signed-off-by: longyue0521 <longyueli0521@gmail.com>
Signed-off-by: longyue0521 <longyueli0521@gmail.com>
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #198 (26cfc72) into dev (72ded6a) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
- Coverage   96.18%   96.05%   -0.13%     
==========================================
  Files          47       47              
  Lines        2542     2538       -4     
==========================================
- Hits         2445     2438       -7     
- Misses         77       79       +2     
- Partials       20       21       +1     
Impacted Files Coverage Δ
syncx/map.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@longyue0521 longyue0521 requested a review from flycash July 13, 2023 02:44
@flycash flycash merged commit 45a0228 into ecodeclub:dev Jul 14, 2023
5 checks passed
@longyue0521 longyue0521 deleted the refactor/syncx/map branch July 14, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants