Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the import issue #317 #318

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

itsgifnotjiff
Copy link
Contributor

Minor readme.md fix but it's weird to have to import polytope_feature instead of polytope, so it might be worth a looksee from someone smarter than me :)

@FussyDuck
Copy link

FussyDuck commented Feb 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (6dcc89c) to head (d2e9bf7).
Report is 319 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
+ Coverage    80.79%   87.14%   +6.34%     
===========================================
  Files          100       42      -58     
  Lines         8123     5148    -2975     
===========================================
- Hits          6563     4486    -2077     
+ Misses        1560      662     -898     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathleur
Copy link
Member

mathleur commented Feb 5, 2025

Hi Yordan @itsgifnotjiff , thanks for the fix! I'd be happy to approve and merge this PR, but would it be possible to sign the CLA before we can merge?

@itsgifnotjiff
Copy link
Contributor Author

Sure thing, sorry about this. I just need to figure out what I am doing wrong or where to sign it.

@itsgifnotjiff
Copy link
Contributor Author

I signed the CLA so hopefully it detects it and you can merge :)

@mathleur
Copy link
Member

Hi @itsgifnotjiff, unfortunately, it doesn’t seem like the CLA recognised the signature. We think it’s possible the email you committed with is not the same as your GitHub email. Would it maybe be possible to try to add the email associated with the commit as secondary GitHub email? Thank you and sorry about the inconvenience!

@itsgifnotjiff
Copy link
Contributor Author

@mathleur you were right, I am sorry for all of this. Now it seems all the checks pass.

@mathleur
Copy link
Member

Great! Yes, thank you for your help! I'll approve the PR now :)

@mathleur mathleur self-requested a review February 10, 2025 14:11
@mathleur mathleur merged commit 2bd7a5b into ecmwf:develop Feb 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants