Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change figure numbering #186

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Change figure numbering #186

merged 4 commits into from
Oct 1, 2024

Conversation

malmans2
Copy link
Member

@malmans2 malmans2 commented Sep 25, 2024

Closes #184

@malmans2 malmans2 requested a review from crgoddard September 25, 2024 08:43
Copy link

Permalinks:

    Copy link

    Previews:

      Copy link

      github-actions bot commented Sep 25, 2024

      PR Preview Action v1.4.8
      Preview removed because the pull request was closed.
      2024-10-01 08:43 UTC

      Copy link
      Collaborator

      @crgoddard crgoddard left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      One question on the seasonal toc, other than that, checking with others if we like the change.

      _toc.yml Outdated Show resolved Hide resolved
      @@ -6,6 +6,7 @@ root: intro
      parts:

      - caption: ➡️ Satellite Observations
      numbered: 3
      Copy link
      Collaborator

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Checking with others if we like this, things start to look a bit strange with 4 levels in the figure numbers.

      Copy link
      Member Author

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      One option is to remove one level. So Satellite Observations shows up in the part caption, then we use flat chapters:

      - caption: ➡️ Satellite Observations
        numbered: 2
        chapters:
        - file: Satellite_ECVs/Atmosphere_Physics/Atmosphere_Physics.md
          sections:
          - glob: Satellite_ECVs/Atmosphere_Physics/*
        - file: Satellite_ECVs/Atmospheric_Composition/Atmospheric_Composition.md
          sections:
          - glob: Satellite_ECVs/Atmospheric_Composition/*
        - file: Satellite_ECVs/Cryosphere/Cryosphere.md
          sections:
          - glob: Satellite_ECVs/Cryosphere/*
        - file: Satellite_ECVs/Land_Biosphere/Land_Biosphere.md
          sections:
          - glob: Satellite_ECVs/Land_Biosphere/*
        - file: Satellite_ECVs/Land_Hydrology/Land_Hydrology.md
          sections:
          - glob: Satellite_ECVs/Land_Hydrology/*
        - file: Satellite_ECVs/Ocean/Ocean.md
          sections:
          - glob: Satellite_ECVs/Ocean/*
      

      @crgoddard crgoddard merged commit da512ad into main Oct 1, 2024
      3 checks passed
      @crgoddard crgoddard deleted the fig-numbering branch October 1, 2024 08:42
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      None yet
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      Figure numbering consistency/update
      2 participants