Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "multiple" prop on Select (fixes #2347) #2356

Merged

Conversation

jchamberlain
Copy link
Contributor

Here are the changes proposed in #2347.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 7685c7d
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66ad52beeb80dd00087fcc9a
😎 Deploy Preview https://deploy-preview-2356--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jchamberlain , thanks for the contribution ❤️
The changes LGTM. Could you pleaserebase them onto the current master to get a (hopefully) clean run of the CI? Thanks!

@lucas-koehler
Copy link
Contributor

@jchamberlain I rebased the changes with Github's builtin functionality. The lint check fails because MuiSelect is not formatted properly. Please apply the formatting accordingly :)

@jchamberlain
Copy link
Contributor Author

Hey @lucas-koehler, formatting applied.

@coveralls
Copy link

Coverage Status

coverage: 83.265%. remained the same
when pulling 7685c7d on jchamberlain:support-multiple-select
into d3ee13a on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks again for the contribution :)

@lucas-koehler lucas-koehler linked an issue Aug 6, 2024 that may be closed by this pull request
@lucas-koehler lucas-koehler merged commit 0096d9a into eclipsesource:master Aug 6, 2024
8 checks passed
@jchamberlain
Copy link
Contributor Author

Thanks, @lucas-koehler! I was going to start using it in my project directly via the master branch, but my ancient version of yarn doesn't like your monorepo (and I can't upgrade yarn just yet). How soon will you be publishing a new release tag? Anything that publishes the individual packages to NPM will work for me. Perhaps you could publish an alpha or beta?

@lucas-koehler
Copy link
Contributor

Hi @jchamberlain , I published a new alpha 3.4.0-alpha.1

@jchamberlain
Copy link
Contributor Author

Perfect. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for multiple prop on Select
4 participants