Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2235 - Update to Jetty 11 #2758

Closed
wants to merge 8 commits into from

Conversation

florianpirchner
Copy link
Contributor

Hi Christian,

i signed the contributor agreement and happy to provide you with this pull request.

Best, Flo

Signed-off-by: Florian Pirchner <florian.pirchner@gmail.com>
Signed-off-by: Florian Pirchner <florian.pirchner@gmail.com>
Signed-off-by: Florian Pirchner <florian.pirchner@gmail.com>
@cdietrich cdietrich added this to the Release_2.32 milestone Jul 22, 2023
@cdietrich
Copy link
Member

thx @florianpirchner
i miss a change to
org.eclipse.xtext.xtext.wizard.WebProjectDescriptor
which still refers to old jetty and slf4j
(start runtime eclipse, choose new xtext project, select web + build system maven or gradle)

@florianpirchner
Copy link
Contributor Author

florianpirchner commented Jul 26, 2023

@cdietrich - i am not sure, why continuous-integration/jenkins/pr-head cannot be built. Found no further information in build, accept:
[ERROR] Failed to resolve target definition file:/home/jenkins/agent/workspace/xtext_PR-2758/org.eclipse.xtext.xbase.lib/../xtext-r202203.target: Could not find "org.aopalliance/1.0.0.v20220404-1927" in the repositories of the current location_

But i did not change anything in the target definition.

Best, Flo

@cdietrich
Copy link
Member

There were changes in orbit. You need to rebase on this mornings change on main branch

@cdietrich
Copy link
Member

@florianpirchner once the build is green, can you rebase/squash etc this pr so that it consists of a single commit.
i will try the wizard locally 2morrow

@florianpirchner
Copy link
Contributor Author

I rebased the commits in a new branch. Is there a way to change the branch in this PR? Or should i create new PR?

Sorry, my first time using PR and google says many different things about best practice.

Best Florian

@cdietrich
Copy link
Member

Guess you have to force push on this branch. Or simply open new pr

@florianpirchner
Copy link
Contributor Author

@cdietrich hi christian, new PR is #2763.

Hope i did everything fine :)

Best Flo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants