Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf warning for 64 bit systems #212

Closed
wants to merge 1 commit into from

Conversation

OlegHahm
Copy link

@OlegHahm OlegHahm commented Dec 6, 2023

No description provided.

@boaks
Copy link
Contributor

boaks commented Dec 7, 2023

Thanks for your contribution.

For open source projects of the Eclipse Foundation some rules for such contributions need to be obeyed to ensure, that others are able to use it with the Eclipse License (EPL 1.0).

Did you read the CONTRIBUTING guidance?

This PR was prepared by two persons. Unfortunately, this is not the standard way, because it introduces some legal uncertainty and therefore requires a CQ (contribution questionnaire, request filled by the project to be proven by eclipse legal.) It would require a ECA by all involved persons.

For now, no one, neither the author nor the committer has signed a ECA, right?

(To be frank, for two line, please clarify, which one of you want to contribute it. Though I'm not longer able to spend more than 4h a week for Californium and tinydtls together, a CQ for 2 lines isn't that productive. I don't make the rules, that the Eclipse Foundation, I have just to ensure, that this rules are applied.)

@OlegHahm
Copy link
Author

OlegHahm commented Dec 7, 2023

I've commited to Eclipse projects before and have signed the ECA. Not sure about @fzi-haxel?

@boaks
Copy link
Contributor

boaks commented Dec 7, 2023

I've commited to Eclipse projects before and have signed the ECA.

I used the eclipse tool to verify the record for the e-mail address, oleg@riot-os.org, used in the commit. According to that record, there is no ECA for that e-mail address.

@OlegHahm
Copy link
Author

OlegHahm commented Dec 7, 2023

Probably used a different email there. @fzi-haxel if you don't have the ECA signed - would you be fine if I amend the commit (using the correct email address)?

@boaks
Copy link
Contributor

boaks commented Dec 7, 2023

I try to write a e-mail to the author ... we will see.

@boaks
Copy link
Contributor

boaks commented Dec 7, 2023

According the e-mail exchange, I extended this fix to zephyr, see PR #217

@boaks boaks closed this Dec 7, 2023
@OlegHahm OlegHahm deleted the pr/64bit_preparation branch December 7, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants