-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 514 #667
Feature/issue 514 #667
Conversation
Added Grafana Added Grafana dashboard provisioning # Conflicts: # .gitpod.dockerfile # .gitpod.yml # server/src/dev/resources/application.yml
@akosyakov @jeanp413 @filiptronicek @kineticsquid @chrisguindon @fredg02 @yiningwang11 I could use some extra 👀 on this PR. Are the metric calculations correct? Does it meet your requirements? |
@amvanbaren, I merged the commits from this PR, https://github.com/eclipse/openvsx/pull/667/commits, into my fork. I restarted my workspace. I can see the Grafana and Prometheus ports but they are not served. This is from my gitpod workspace, https://kineticsquid-openvsx-pj1w63erlez.ws-us84.gitpod.io/. I'm guessing I didn't do this step correctly, |
@kineticsquid There's no need to merge. Install the Gitpod addon: https://addons.mozilla.org/nl/firefox/addon/gitpod/. Then at the top of the page, a Gitpod button is added: |
@amvanbaren Pretty slick! I was able to get this to work and see the dashboard. A couple of questions.
More general question. How does gitpod construct the workspace? I poked around a bit for some documentation, but didn't find any detail. It looks like gitpod creates the workspace by cloning the repo and then merging the PR. |
I think it is mostly a question to Eclipse folks. At Gitpod we have our own dashboards/alerts/SLOs which rely on spring metrics. We could share what we have if @kineticsquid if you think it would be useful to you. |
An error is defined as a 5xx (server error) or 4xx (client error).
I think the IP address can be added to the data.
The Gitpod workspace is for demonstration purposes. The Eclipse IT team will have to setup Prometheus and Grafana themselves. |
@amvanbaren Even a 404 shows up as an error? It seems useful to separate our 5xx server errors from 4xx user errors. On the gitpod workspace construction, I was attempting to ask a more general question. How does gitpod construct a workspace from a PR? |
@kineticsquid I've split server and client errors into separate panels. Gitpod uses Docker to construct a workspace from a PR. |
Using #857 instead. |
Fixes #514
Testing Steps
admin
, password:admin
. Just clickskip
when it asks for a new password.Dashboards > General
.