Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 514 #667

Closed
wants to merge 5 commits into from
Closed

Conversation

amvanbaren
Copy link
Contributor

@amvanbaren amvanbaren commented Jan 30, 2023

Fixes #514

Testing Steps

  • Open this PR in Gitpod using the Gitpod browser plugin. It will automatically setup Prometheus and Grafana.
  • Once the Gitpod workspace has initialized, you can view the dashboards on port 9999 (https://9999-<GITPOD_HOST>).
  • When Grafana prompts for credentials use: username: admin, password: admin. Just click skip when it asks for a new password.
  • Dashboards are located under Dashboards > General.

amvanbaren added 4 commits January 27, 2023 11:45
Added Grafana
Added Grafana dashboard provisioning

# Conflicts:
#	.gitpod.dockerfile
#	.gitpod.yml
#	server/src/dev/resources/application.yml
@amvanbaren amvanbaren self-assigned this Jan 30, 2023
@amvanbaren amvanbaren marked this pull request as draft January 30, 2023 13:12
@amvanbaren
Copy link
Contributor Author

@akosyakov @jeanp413 @filiptronicek @kineticsquid @chrisguindon @fredg02 @yiningwang11 I could use some extra 👀 on this PR. Are the metric calculations correct? Does it meet your requirements?

@kineticsquid
Copy link
Contributor

@amvanbaren, I merged the commits from this PR, https://github.com/eclipse/openvsx/pull/667/commits, into my fork. I restarted my workspace. I can see the Grafana and Prometheus ports but they are not served. This is from my gitpod workspace, https://kineticsquid-openvsx-pj1w63erlez.ws-us84.gitpod.io/.

I'm guessing I didn't do this step correctly, Open this PR in Gitpod using the Gitpod browser plugin. It will automatically setup Prometheus and Grafana..

@amvanbaren
Copy link
Contributor Author

@kineticsquid There's no need to merge. Install the Gitpod addon: https://addons.mozilla.org/nl/firefox/addon/gitpod/. Then at the top of the page, a Gitpod button is added:
Schermafbeelding 2023-01-31 om 22 00 05

@kineticsquid
Copy link
Contributor

@amvanbaren Pretty slick! I was able to get this to work and see the dashboard. A couple of questions.

  • What defines an error, e.g. a 5xx http response?
  • Are we also able to track the source of the call?

More general question. How does gitpod construct the workspace? I poked around a bit for some documentation, but didn't find any detail. It looks like gitpod creates the workspace by cloning the repo and then merging the PR.

@akosyakov
Copy link
Member

akosyakov commented Feb 2, 2023

I think it is mostly a question to Eclipse folks. At Gitpod we have our own dashboards/alerts/SLOs which rely on spring metrics. We could share what we have if @kineticsquid if you think it would be useful to you.

@amvanbaren
Copy link
Contributor Author

@kineticsquid

What defines an error, e.g. a 5xx http response?

An error is defined as a 5xx (server error) or 4xx (client error).

Are we also able to track the source of the call?

I think the IP address can be added to the data.

More general question. How does gitpod construct the workspace?

The Gitpod workspace is for demonstration purposes. The Eclipse IT team will have to setup Prometheus and Grafana themselves.

@kineticsquid
Copy link
Contributor

@amvanbaren Even a 404 shows up as an error? It seems useful to separate our 5xx server errors from 4xx user errors.

On the gitpod workspace construction, I was attempting to ask a more general question. How does gitpod construct a workspace from a PR?

@amvanbaren
Copy link
Contributor Author

@kineticsquid I've split server and client errors into separate panels.

Gitpod uses Docker to construct a workspace from a PR.

@amvanbaren amvanbaren mentioned this pull request Jan 23, 2024
@amvanbaren
Copy link
Contributor Author

Using #857 instead.

@amvanbaren amvanbaren closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add observability on endpoints
3 participants