Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors using gcc 13 #7325

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix build errors using gcc 13 #7325

merged 2 commits into from
May 6, 2024

Conversation

keithc-ca
Copy link
Member

  • fix a use-after-free problem in omrfilestream.c
  • fix a stringop-overflow error in OMRSimplifierHandlers.cpp

@keithc-ca
Avoid "use-after-free" warning with gcc 13
0b20034 
Using a FILE* handle after a call to fclose() (even for tracing)
counts as use-after-free problem.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Fix stringop-overflow error in OMRSimplifierHandlers.cpp
b776f8e 
gcc 13 believes two entries per bit are required

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
babsingh
babsingh approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port library change LGTM

@0xdaryl
Copy link
Contributor

0xdaryl commented May 6, 2024

Jenkins build all

@0xdaryl 0xdaryl self-assigned this May 6, 2024
@0xdaryl 0xdaryl merged commit 1bcf969 into eclipse:master May 6, 2024
15 of 18 checks passed
@keithc-ca keithc-ca deleted the gcc13 branch May 6, 2024 18:48
keithc-ca added a commit to keithc-ca/omr that referenced this pull request May 13, 2024
@keithc-ca
Remove trace-point that requires use-after-close reference
9fc4a86 
It turns out that eclipse#7325 was ineffective: compilers see straight
through that attempt to hide the use-after-close. The trace-point
doesn't provide any information that isn't already available by
other trace-points at the same level.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca keithc-ca mentioned this pull request May 13, 2024
Merged
rmnattas pushed a commit to rmnattas/omr that referenced this pull request Jun 14, 2024
@keithc-ca @rmnattas
Remove trace-point that requires use-after-close reference
c1ca8bd 
It turns out that eclipse#7325 was ineffective: compilers see straight
through that attempt to hide the use-after-close. The trace-point
doesn't provide any information that isn't already available by
other trace-points at the same level.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

@0xdaryl 0xdaryl 0xdaryl approved these changes

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner

Assignees

@0xdaryl 0xdaryl

Labels
comp:compiler comp:port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithc-ca @0xdaryl @babsingh