Introduce flag gcThreadsCountSpecified #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitripivkine please, review |
amicic
force-pushed
the
gcthreads_specified
branch
from
57a7e59
to
6ffc89b
Compare
gc/base/Configuration.cpp
Outdated
| @@ -445,15 +445,17 @@ MM_Configuration::initializeArrayletLeafSize(MM_EnvironmentBase* env) | |||
| void | |||
| MM_Configuration::initializeGCThreadCount(MM_EnvironmentBase* env) | |||
| { | |||
| OMRPORT_ACCESS_FROM_ENVIRONMENT(env); | |||
There was a problem hiding this comment.
Is this line necessary?
amicic
force-pushed
the
gcthreads_specified
branch
from
6ffc89b
to
8f01bdd
Compare
dmitripivkine
approved these changes
Dec 15, 2023
amicic
force-pushed
the
gcthreads_specified
branch
from
8f01bdd
to
260408f
Compare
|
@babsingh please review. For some reason ECA is failing!? |
This flag is to be used along existing gcThreadCountForced. Specified flag will be used to distinguish between GC thread count calculated by default or specified by a command line option. Forced flag will to be used for a subset of options that force a fixed number of threads. Currently Forced is used as Specified, but we need both to distinguish among 3 posibilities, specifically in Java: default, Xgcthreads and Xgcmaxthreads. Changes that will make that behavior effective will follow up later, once downstream projects properly adjust command line parsing and setting these flags. Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
amicic
force-pushed
the
gcthreads_specified
branch
from
260408f
to
d253adb
Compare
|
jenkins build all |
|
Only known failures are seen in the PR builds: |
babsingh
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is to be used along existing gcThreadCountForced. Specified
flag will be used to distinguish between GC thread count calculated by
default or specified by a command line option. Forced flag
will to be used for a subset of options that force a fixed number of
threads.
Currently Forced is used as Specified, but we need both to distinguish
among 3 posibilities, specifically in Java: default, Xgcthreads and
Xgcmaxthreads.
Changes that will make that behavior effective will follow up later,
once downstream projects properly adjust command line parsing and
setting these flags.