Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade spock to 2.3 and groovy to 3.0.19 #1263

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

reinsch82
Copy link
Contributor

No description provided.

@reinsch82 reinsch82 changed the title upgrade spock to 2.3 upgrade spock to 2.3 and groovy to 3.0.19 Sep 19, 2023
update groovy to 3.0.19 and spock to 2.3
@donat donat merged commit 3a4bac3 into eclipse:master Sep 28, 2023
2 checks passed
@akurtakov
Copy link

Did all these changes been ip approved by e.g. https://github.com/eclipse/dash-licenses/ ? I'm trying to move Jdt.ls to latest buildship and face a license issue eclipse-jdtls/eclipse.jdt.ls#2974 .

@donat
Copy link
Contributor

donat commented Nov 22, 2023

Groovy and Spock are test-only dependencies and they should not appear anywhere in production.

@akurtakov
Copy link

My bad I wanted to ask for org.gradle.toolingapi. No idea why I actually asked at this PR.

@donat
Copy link
Contributor

donat commented Nov 22, 2023

All right.

Regarding the org.gradle.toolingapi dependency: years ago the Eclipse IP team allowed us to update the tapi versions without an explicit license review.

@akurtakov
Copy link

Regarding the org.gradle.toolingapi dependency: years ago the Eclipse IP team allowed us to update the tapi versions without an explicit license review.

@waynebeaton Can this permission be somehow handled in the dash tool database or the tool itself so buildship downstreams can rely on dash licensetool?

@waynebeaton
Copy link
Member

The easiest thing to do is to remove the the component from the information that you pass to the tool.

For the Maven plugin, you can use the excludeArtifactIds property. If you're invoking the CLI, you can use grep to filter out the entries that don't need to be reviewed.

In the meantime, I have a prototype extension that should help us find new versions of the source.

@waynebeaton
Copy link
Member

@donat where do I find downloads (especially of source) of org.gradle:gradle-tooling-api:*.

I'm looking specifically for some kind of archive format, not a pointer to the source tree in a Git repository (I can make the latter work, but an archive file is better for a couple of reasons). Scanning these should be easy enough, so I'd like to set us up for future success (other projects have asked for this dependency).

In the meantime... I grabbed the ZIP of the source from the Eclipse Buildship project; we'll use that to push through the review of this version.

@donat
Copy link
Contributor

donat commented Nov 24, 2023

The source jar is available here: gradle-tooling-api-8.1.1-sources.jar

@waynebeaton
Copy link
Member

Thanks. In the future, the IPLab scanner will look on repo.gradle.org for source for this and other org.gradle packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants