Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Properties support #1242

Merged
merged 77 commits into from
Jul 24, 2023
Merged

Gradle Properties support #1242

merged 77 commits into from
Jul 24, 2023

Conversation

D0zee
Copy link
Contributor

@D0zee D0zee commented Jun 28, 2023

Implemented for gradle.properties files:

  • Auto-completion for static gradle properties
  • Simple diagnostic: if there is property with a equal sign, value for one must be
  • Syntax highlighting
  • Searching compatible jvms for launching Gradle Properties language server
  • UI test via SWT bot (in another PR)

D0zee added 27 commits June 12, 2023 09:50
…dlePropertiesConnectionProvider, output directory and name are changed in shadowJar task
@donat donat self-assigned this Jun 29, 2023
@donat donat self-requested a review June 29, 2023 07:24
@donat
Copy link
Contributor

donat commented Jun 29, 2023

Please fix the validation failure. You probably need to sign the Eclipse Contributor Agreement. Check https://www.eclipse.org/projects/handbook/#resources-github for details.

Copy link
Contributor

@donat donat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More feedback on the recent changes.

D0zee and others added 16 commits July 19, 2023 10:19
…buildship/gradleprop/ls/GradlePropertiesLanguageServer.java


language client inside gradle prop server has been made privat

Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java

Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java

Co-authored-by: Donát Csikós <csdonat@gmail.com>
Co-authored-by: Donát Csikós <csdonat@gmail.com>
Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java

Co-authored-by: Donát Csikós <csdonat@gmail.com>
…s, updated language-server.jar, resolved question with exit code in GradleLanguageServer
…l classes, updated language-server.jar, resolved question with exit code in GradleLanguageServer"

This reverts commit e2a14fb.
…me in all classes, updated language-server.jar, resolved question with exit code in GradleLanguageServer""

This reverts commit 35485d4.
This reverts commit 506d010.
@donat donat self-requested a review July 24, 2023 15:37
@donat donat merged commit 17af5f0 into eclipse:master Jul 24, 2023
1 check failed
@donat donat added this to the 3.1.8 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants