-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle Properties support #1242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlePropertiesConnectionProvider, output directory and name are changed in shadowJar task
…re inside plugin.xml in Provider
…ed from setting.gradle.kts
…extra scripts for starting server at all
Please fix the validation failure. You probably need to sign the Eclipse Contributor Agreement. Check https://www.eclipse.org/projects/handbook/#resources-github for details. |
donat
reviewed
Jul 18, 2023
...rop.ls/src/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesLanguageServer.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...rc/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...rc/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...rc/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...rc/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...s/src/main/java/org/eclipse/buildship/gradleprop/ls/GradlePropertiesTextDocumentService.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
org.eclipse.buildship.gradleprop.provider/src/syntax/Kotlin.tmLanguage.json
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...ovider/src/org/eclipse/buildship/gradleprop/provider/GradlePropertiesConnectionProvider.java
Outdated
Show resolved
Hide resolved
donat
reviewed
Jul 18, 2023
...ovider/src/org/eclipse/buildship/gradleprop/provider/GradlePropertiesConnectionProvider.java
Outdated
Show resolved
Hide resolved
donat
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More feedback on the recent changes.
…buildship/gradleprop/ls/GradlePropertiesLanguageServer.java language client inside gradle prop server has been made privat Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java Co-authored-by: Donát Csikós <csdonat@gmail.com>
Co-authored-by: Donát Csikós <csdonat@gmail.com>
Co-authored-by: Donát Csikós <csdonat@gmail.com>
…buildship/gradleprop/ls/GradlePropertiesLanguageServerLauncher.java Co-authored-by: Donát Csikós <csdonat@gmail.com>
…s, updated language-server.jar, resolved question with exit code in GradleLanguageServer
…l classes, updated language-server.jar, resolved question with exit code in GradleLanguageServer" This reverts commit e2a14fb.
…me in all classes, updated language-server.jar, resolved question with exit code in GradleLanguageServer"" This reverts commit 35485d4.
This reverts commit 506d010.
donat
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented for gradle.properties files: