-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: precise query id rollover semantic #1606
base: main
Are you sure you want to change the base?
Conversation
PR missing one of the required labels: {'enhancement', 'dependencies', 'breaking-change', 'internal', 'documentation', 'bug', 'new feature'} |
Allow managing rollover and uniqueness, as well as being faster to access.
08e13ba
to
a2b1583
Compare
@wyfo what's the status of this PR? |
I've realized that just making the query id available right after a timeout is not appropriate, because some response may come after. A better solution in case of timeout would be to add another delay, for example 1min in which the query id cannot be reused. And to handle the case where a lot of queries time out, those pending ids could be be inserted in a dedicated set, to be reused only in case of available id shortage. |
I think the proposed change introduces quite a bit of complexity. We could simply rollover on |
I think it's a valid assumption, but it quite defeats the point of having varint encoding for request id. |
There might be some room for optimization indeed but I don't believe it's critical. |
I've updated the PR taking in account the recent discussion. |
Allow managing rollover and uniqueness, as well as being faster to access.