Merge main into dev/1.0.0 #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
* fix: Improve debug messages for failing RX/TX tasks * fix: Improve debug message for `accept_link` timeout * chore: Fix `clippy::redundant_pattern_matching` error
* Yield task for backoff * Improve comments and error handling in backoff * Simplify pipeline pull * Consider backoff configuration
* Fix typos * Add typos check to CI
* bump quinn & rustls * fix ci windows check * add comments
…TLS/QUIC/WS (#1123) Co-authored-by: Julien Enoch <julien.e@zettascale.tech>
…clarations to void dead locks (#1150) * Send simple sub and qabl declarations using a given function * Send simple sub and qabl declarations after releasing tables lock * Send simple sub and qabl declarations after releasing tables lock (missing places)
* fix: zenohd --cfg * ci: trigger * Update zenohd/src/main.rs --------- Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
* Change missleading log * Fix failover brokering bug reacting to linkstate changes * Retrigger CI --------- Co-authored-by: Luca Cominardi <luca.cominardi@gmail.com>
* Allow unexpected `doc_auto_cfg` flag * Keep never-constructed logger interceptor * Ignore interior mutability of `Resource` * Fix typo * Resolve `clippy::doc-lazy-continuation` errors * Upgrade `time@0.3.28` to `time@0.3.36` See time-rs/time#693
Updated description to be aligned with what we use everywhere else
* Replace trees computation tasks with a worker * Address review comments * Remove review comments
* Zenohd panic when tring load file When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic. * zenohd default config error #1292 When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type. I treat it return a Default Config whe it happen * If file fail when try load configs If file fail when try load configs * Update main.rs * Resolve typos at comment Resolve typos at comment
* Zenohd panic when tring load file When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic. * zenohd default config error #1292 When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type. I treat it return a Default Config whe it happen * If file fail when try load configs If file fail when try load configs * Update main.rs * Resolve typos at comment Resolve typos at comment
* Replace trees computation tasks with a worker * Address review comments * Remove review comments
Mallets
reviewed
Aug 27, 2024
zenohd/src/main.rs
Outdated
| Config::from_file(conf_file).unwrap_or_else(|e| { | ||
| // if file load fail, wanning it, and load default config | ||
| tracing::warn!("Warn: File {} not found! {}", conf_file, e.to_string()); | ||
| Config::default() |
There was a problem hiding this comment.
If config file is provided as CLI arg and the file does not exist, I believe we should just return an error and exit. I don't think it's a good a idea to silently fallback to a default configuration here.
There was a problem hiding this comment.
This was done in this PR:
#1298
Yes, seems like the approach to fix that was wrong, need to correct our DEAFULT_CONFIG.json5 instead
There was a problem hiding this comment.
Not only DEFAULT_CONFIG.json5, I believe zenohd should refuse to start if wrong parameters are passed and not to silently fallback. The user may not even see the traficing warn if zenohd is run in a container. But it's very apparent if zenohd does not start at all.
There was a problem hiding this comment.
Reverted the fix, reopened issue #1292
Mallets
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.