Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename KeyExpr::from_boxed_string_unchecked to KeyExpr::from_boxed_str_unchecked #1288

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Rename KeyExpr::from_boxed_string_unchecked to KeyExpr::from_boxed_str_unchecked #1288

merged 1 commit into from
Jul 31, 2024

Conversation

fuzzypixelz
Copy link
Member

A Box<str> implies boxed_str and not boxed_string (that would be Box<String> which doesn't make sense).

An std example of this is std::string::String::into_boxed_str.

@fuzzypixelz fuzzypixelz self-assigned this Jul 31, 2024
@fuzzypixelz fuzzypixelz added breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better labels Jul 31, 2024
@Mallets Mallets merged commit f394867 into eclipse-zenoh:dev/1.0.0 Jul 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees

@fuzzypixelz fuzzypixelz

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzypixelz @Mallets