Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Error trait for ZBytes error types #1192

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Jun 26, 2024

@Mallets
Copy link
Member Author

Mallets commented Jun 26, 2024

@wyfo this PR is in response to your comment in eclipse-zenoh/zenoh-python#240

@wyfo
Copy link
Contributor

wyfo commented Jun 26, 2024

I've missed #1174... (I'm watching all activities of the repository now, will not miss a PR again).
I don't like these new error types, that make the API so much more complex. I think we just should use Box<dyn Error> everywhere.
Also, we track tuple member path, but not sequence element path, so it's not very consistent to me.

Anyway, I've nothing to say about this particular PR, LGTM.

EDIT: by sequence element path, I mean that when you deserialize a list or a map (which will surely be the main use of the tuple deserialization), you don't know which element failed, so you may know for a map that's a key error, but not on which position, and that's not very useful.

@Mallets Mallets merged commit fc18f90 into dev/1.0.0 Jun 26, 2024
19 checks passed
@Mallets Mallets deleted the feat/bytes_error_trait branch June 26, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants