-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROS test with CI. #350
Conversation
PR missing one of the required labels: {'internal', 'documentation', 'breaking-change', 'enhancement', 'bug', 'new feature', 'dependencies'} |
The failure is related to this #351 |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
9b99923
to
b030d70
Compare
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@JEnoch I can test pub/sub between ROS and Zenoh now. Tested both in Humble and Jazzy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the setting of RMW_IMPLEMENTATION=rmw_cyclonedds_cpp
should be hard-coded in the tests. Otherwise, r2r
picks the default RMW which won't fully work with the bridge if not CycloneDDS.
I think it's fine to have just pub/sub in a first PR, and to add others later. But as most of users are using the plugin to bridge 2 distinct DDS domains (different hosts without DDS comms or different domains), I would also like to see such tests. |
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
I don't think so. I looked into the ROS code. Indeed, we can use |
In our current CI, there is no test on the transformation between ROS and Zenoh.
This makes our development less efficient and makes it impossible to ensure quality when it comes to more and more combinations of tests.
For example, how to make sure our tests can work in both Humble and Jazzy? When it comes to different environmental variables, how to know it won't break the backward compatibility?
The PR is a trial to see how it works by using r2r.