Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api alignment #146

Merged
merged 63 commits into from
Aug 19, 2024
Merged

Api alignment #146

merged 63 commits into from
Aug 19, 2024

Conversation

DariusIMP
Copy link
Member

@DariusIMP DariusIMP commented Jul 29, 2024

  • Removed all the resolvables and all the builder patterns. Using default arguments instead.
  • Converted a couple of classes into 'data' classes.
  • Selector: fix using empty string for parameters, now using optional string.
  • Removing the Attachment class, and passing instead a ZBytes instance.
  • Implementation of the ZBytes class
  • Implementation of the serialization & deserialization logic
    • Serialization for:
      • Numeric types
      • String type
      • ByteArray type
      • List, where T is one of the raw types mentioned, or can be a custom class implementing the Serializable interface.
      • Map<T, T>, where T is again, one of the raw types mentioned or types implementing the Serializable interface.
    • Deserialization for:
      • Numeric types
      • String type
      • ByteArray type
      • List, where T is one of the raw types mentioned, or can be a custom class implementing the Deserializable interface.
      • Map<T, T>, where T is again, one of the raw types mentioned or types implementing the Deserializable interface.
    • Added some ZBytes tests
    • Added a ZBytes example.

@DariusIMP DariusIMP marked this pull request as ready for review August 2, 2024 13:03
@DariusIMP DariusIMP marked this pull request as draft August 2, 2024 14:41
@DariusIMP DariusIMP marked this pull request as ready for review August 2, 2024 17:51
DariusIMP and others added 9 commits August 17, 2024 01:26
* build: Sync  with eclipse-zenoh/zenoh@9d09742 from 2024-06-11 (eclipse-zenoh#109)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@ed6c636 from 2024-06-12 (eclipse-zenoh#112)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@8160b01 from 2024-06-13 (eclipse-zenoh#115)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* Enable releasing from any branch (eclipse-zenoh#114)

* build: Sync  with eclipse-zenoh/zenoh@7adad94 from 2024-06-14 (eclipse-zenoh#117)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@93f93d2 from 2024-06-17 (eclipse-zenoh#118)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@2500e5a from 2024-06-20 (eclipse-zenoh#119)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@869ace6 from 2024-07-02 (eclipse-zenoh#120)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@b93ca84 from 2024-07-03 (eclipse-zenoh#121)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* Enabling snapshot publications for dev/1.0.0 on the CI

* fix: wrong syntax in ci workflow (eclipse-zenoh#124)

* build: Sync  with eclipse-zenoh/zenoh@b3e42ce from 2024-07-08 (eclipse-zenoh#126)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* Update main release workflow (eclipse-zenoh#133)

* Using 'android' property to enable/disable Android configuration (eclipse-zenoh#127)

* Enabling snapshot publications for dev/1.0.0

* refactor(gradle): using 'android' property to enable/disable Android configuration

Examples:
- `gradle build -Pandroid=true` enables build with android
- `gradle build` won't consider any android configuration
- `gradle publishAndroidReleaseToMavenLocal -Pandroid=true` publishes to maven local,
	without `-Pandroid=true` it won't work.

* refactor(gradle): updating publication workflows

* refactor(gradle): updating readme instructions

---------

Co-authored-by: zettascale-bot <161707711+zettascale-bot@users.noreply.github.com>

* fix(local publication): triggering compilation of zenoh jni when publishing jvm to maven local (eclipse-zenoh#128)

* Update actions (eclipse-zenoh#130)

* chore: Update setup-java to v4

* chore: update gradle action to newer version

* chore: update gradle/wrapper-validation-action@v3

---------

Co-authored-by: Darius Maitia <darius@zettascale.tech>
Co-authored-by: zettascale-bot <161707711+zettascale-bot@users.noreply.github.com>

* fix: Update gradle actions to newer versions (eclipse-zenoh#134)

* fix: Update buildDir usage for gradle 8

* Update gradle wrapper action to newer version

* calling gradle action via arguments is deprecated

* fix: remove unnecessary call to buildDir()

* fix: add -Pandroid to gradle dokkaHtml call

Otherwise the docs won't build

* Fix documentation publication error on CI (eclipse-zenoh#136)

* build: Sync  with eclipse-zenoh/zenoh@0a969cb from 2024-07-25 (eclipse-zenoh#141)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@e587aa9 from 2024-07-26 (eclipse-zenoh#144)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* build: Sync  with eclipse-zenoh/zenoh@2d88c7b from 2024-07-29 (eclipse-zenoh#147)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>

* Fix JVM crash when finalizing a session that wasn't properly initialized (eclipse-zenoh#139) (eclipse-zenoh#140)

* Fix snapshot publications on the CI (eclipse-zenoh#149)

* Fix ZPubThr example imports (eclipse-zenoh#142)

---------

Co-authored-by: eclipse-zenoh-bot <61247838+eclipse-zenoh-bot@users.noreply.github.com>
Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>
Co-authored-by: Mahmoud Mazouz <mazouz.mahmoud@outlook.com>
Co-authored-by: kydos <kydos@protonmail.com>
Co-authored-by: Diogo Matsubara <diogo.matsubara@zettascale.tech>
Co-authored-by: zettascale-bot <161707711+zettascale-bot@users.noreply.github.com>
Co-authored-by: Jonathan Hepp <jonathan.hepp@gmail.com>
…-zenoh#155)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>
…-zenoh#156)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>
…-zenoh#157)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>
)

* Add Consolidation::Auto to JNI and Kotlin API

* Use default consolidation in ZGet example
* Change default consolidation mode to AUTO

* Implement default function for ConsolidationMode
…-zenoh#166)

Co-authored-by: eclipse-zenoh-bot <eclipse-zenoh-bot@users.noreply.github.com>
When processing the internal string representation of a kotlin KeyExpr instance
through JNI, a rust KeyExpr instance was generated through the "try_from" function.
This is unnecessary since the string representation was already validated during the
construction phase of the KeyExpr object on Kotlin.
Therefore, this commit introduces an optimization in which the rust key expression
is created with "from_string_unchecked", since we already guarantee that the string
representation provided is valid and has already been checked.
@Mallets Mallets merged commit c6aff70 into eclipse-zenoh:dev/1.0.0 Aug 19, 2024
3 of 6 checks passed
DariusIMP added a commit to ZettaScaleLabs/zenoh-kotlin that referenced this pull request Aug 19, 2024
Mallets added a commit that referenced this pull request Aug 19, 2024
@Mallets Mallets mentioned this pull request Aug 19, 2024
Mallets added a commit that referenced this pull request Aug 19, 2024
@DariusIMP DariusIMP mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants