Fix build with CMAKE_BUILD_TYPE=None #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jspricke , Thanks for your PR. In order to merge it we need you to sign the Eclipse ECA: https://api.eclipse.org/git/eca/status/gh/eclipse-zenoh/zenoh-c/358. Once this is done, we can move forward with the review of your PR. |
jspricke
force-pushed
the
build_none
branch
2 times, most recently
from
eb418e9 to
9464469
Compare
This is the default build type for debhelper (Debian).
|
@JEnoch done. Btw. I would recommend special casing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default build type for debhelper (Debian).