-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Setup Read the Docs webhooks #8
Conversation
This is your friendly self-service bot. The author (fuzzypixelz) of this PR is associated with this organization in the role of The author (fuzzypixelz) of this PR is not a member of this organization. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
can you also set a secret for the webhook and share it with us as explained at: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Sharing-secrets ? Once the secret is received, I will update the PR accordingly. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f5ce07f
to
7b33f45
Compare
Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
This is your friendly self-service bot. Diff for 0d991ceOrganization iot.zenoh[id=eclipse-zenoh]
there have been 20 validation infos, enable verbose output with '-v' to to display them.
- remove repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-c/135565/", repository="zenoh-c"] {
- active = true
- content_type = "json"
- events = [
- "create"
- "delete"
- "push"
- ],
- insecure_ssl = "0"
- secret = null
- url = "https://readthedocs.org/api/v2/webhook/zenoh-c/135565/"
- }
+ add repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-c/263729/", repository="zenoh-c"] {
+ active = true
+ content_type = "json"
+ events = [
+ "create"
+ "delete"
+ "push"
+ "pull_request"
+ ],
+ insecure_ssl = "0"
+ secret = "pass:bots/iot.zenoh/readthedocs.org/zenoh-c-webhook-secret"
+ url = "https://readthedocs.org/api/v2/webhook/zenoh-c/263729/"
+ }
+ add repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-cpp/263743/", repository="zenoh-cpp"] {
+ active = true
+ content_type = "json"
+ events = [
+ "create"
+ "delete"
+ "push"
+ "pull_request"
+ ],
+ insecure_ssl = "0"
+ secret = "pass:bots/iot.zenoh/readthedocs.org/zenoh-cpp-webhook-secret"
+ url = "https://readthedocs.org/api/v2/webhook/zenoh-cpp/263743/"
+ }
+ add repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-pico/263750/", repository="zenoh-pico"] {
+ active = true
+ content_type = "json"
+ events = [
+ "create"
+ "delete"
+ "push"
+ "pull_request"
+ ],
+ insecure_ssl = "0"
+ secret = "pass:bots/iot.zenoh/readthedocs.org/zenoh-pico-webhook-secret"
+ url = "https://readthedocs.org/api/v2/webhook/zenoh-pico/263750/"
+ }
- remove repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-python/135566/", repository="zenoh-python"] {
- active = true
- content_type = "form"
- events = [
- "push"
- ],
- insecure_ssl = "0"
- secret = null
- url = "https://readthedocs.org/api/v2/webhook/zenoh-python/135566/"
- }
+ add repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-python/263749/", repository="zenoh-python"] {
+ active = true
+ content_type = "json"
+ events = [
+ "create"
+ "delete"
+ "push"
+ "pull_request"
+ ],
+ insecure_ssl = "0"
+ secret = "pass:bots/iot.zenoh/readthedocs.org/zenoh-python-webhook-secret"
+ url = "https://readthedocs.org/api/v2/webhook/zenoh-python/263749/"
+ }
Plan: 4 to add, 0 to change, 2 to delete. Warnings
cc @eclipse-zenoh/eclipsefdn-security Add a comment |
This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀 |
LGTM, can a project lead approve? Ty |
+1 |
This is your friendly self-service bot. The following changes have been successfully applied: Organization iot.zenoh[id=eclipse-zenoh]
there have been 20 validation infos, enable verbose output with '-v' to to display them.
- remove repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-c/135565/", repository="zenoh-c"] {
- active = true
- content_type = "json"
- events = [
- "create"
- "delete"
- "push"
- ],
- insecure_ssl = "0"
- secret = null
- url = "https://readthedocs.org/api/v2/webhook/zenoh-c/135565/"
- }
- remove repo_webhook[url="https://readthedocs.org/api/v2/webhook/zenoh-python/135566/", repository="zenoh-python"] {
- active = true
- content_type = "form"
- events = [
- "push"
- ],
- insecure_ssl = "0"
- secret = null
- url = "https://readthedocs.org/api/v2/webhook/zenoh-python/135566/"
- }
Applying changes:
Done.
Executed plan: 0 added, 0 changed, 2 deleted. NoteThe pull request was only partially applied as it requires some access to secrets, please apply the remaining changes |
/done |
The PR has been marked as being completed. |
The zenoh-c Read the Docs webook has been failing for a while with the following error:
This can apparently be fixed by regenerating the webhook URL and secret (or using the "resync webhook" feature in Read the Docs, but that would require the actor to have admin permissions on zenoh-c?).
However, there is the issue of supplying the secret, which wasn't there to beging with (maybe that's another reason why the hook was failing?). We would have to somehow exchange the secret through some means other than this pull request.
Moreover, we're looking to add
pull_request
to the webhook events as explained here to include documentation builds in CI.