Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Logging errors #145

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Fix Logging errors #145

merged 4 commits into from
Feb 16, 2023

Conversation

gabrik
Copy link
Contributor

@gabrik gabrik commented Feb 15, 2023

Before:

[2023-02-15T08:55:05Z ERROR zenoh_flow_daemon::worker] [Worker: 0] Got error when running Job: d4b2f452-bb3b-4cfc-8384-2d516dbe9142 - ZenohError

After:

[2023-02-15T08:55:05Z ERROR zenoh_flow_daemon::worker] [Worker: 0] Got error when running Job: d4b2f452-bb3b-4cfc-8384-2d516dbe9142 - ZenohError None at zenoh-flow/src/zfresult.rs:279. Description: Some("IOError Some(No such file or directory (os error 2): /home/ato/Workspace/zenoh-flow-examples/montblanc/target/release/libhebron.so) at zenoh-flow/src/utils.rs:58. Description: Some(\"No such file or directory (os error 2): /home/ato/Workspace/zenoh-flow-examples/montblanc/target/release/libhebron.so\")")

@gabrik
adding string description for errors, and fix the their logging
735e9b8 
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
@gabrik gabrik requested a review from J-Loudet February 15, 2023 09:55
@gabrik
fix format
0ba2dcb 
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
@gabrik gabrik changed the base branch from master to 0.4.x February 15, 2023 09:56
@gabrik gabrik marked this pull request as ready for review February 15, 2023 09:56
gabrik and others added 2 commits February 15, 2023 11:57
@gabrik
fix clippy issues
a24576d 
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
fix: remove duplicated + improve format
ca8c2bc
@gabrik gabrik merged commit dcfce88 into 0.4.x Feb 16, 2023
J-Loudet pushed a commit that referenced this pull request Feb 17, 2023
@gabrik
Fix Logging errors (#145)
403a348 
* adding string description for errors, and fix the their logging

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix format

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix clippy issues

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix: remove duplicated + improve format

---------

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Co-authored-by: Julien Loudet <julien.loudet@zettascale.tech>
J-Loudet pushed a commit that referenced this pull request Feb 21, 2023
@gabrik
Fix Logging errors (#145)
c18ab58 
* adding string description for errors, and fix the their logging

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix format

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix clippy issues

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>

* fix: remove duplicated + improve format

---------

Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Co-authored-by: Julien Loudet <julien.loudet@zettascale.tech>
@gabrik gabrik deleted the fix-logging-errors branch February 28, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Loudet J-Loudet Awaiting requested review from J-Loudet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrik