fix: errors in transaction handling #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prv_get_transaction did return non-matching transaction if only one transaction was in the list or only session or mid did match - prv_checkFinished did not check if the mid did match, resulting in a wrong transaction to be removed in transaction_handleResponse Signed-off-by: Pascal Brogle <pascal.brogle@husqvarnagroup.com>
mlasch
approved these changes
Oct 1, 2021
|
This is an important fix, @tuve do you also want to have a look? |
tuve
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prv_get_transactiondid return non-matching transaction if only onetransaction was in the list or only session or mid did match
prv_checkFinisheddid not check if the mid did match, resulting in a wrongtransaction to be removed in
transaction_handleResponse