Pg Client might convert a query param to NULL if it has the wrong type #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-vertx#1463 With this change, a DataType always has a param extractor. The default extractor signals the failure to convert to PgParamDesc. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
issue/1463
branch
from
d934260 to
afeb274
Compare
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Sep 17, 2024
eclipse-vertx#1464) Fixes eclipse-vertx#1463 With this change, a DataType always has a param extractor. The default extractor signals the failure to convert to PgParamDesc. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Jan 17, 2025
See eclipse-vertx#1477 This is a regression introduced in eclipse-vertx#1464 When the value is null, the extractor throws a failure. Then, in ErrorMessageFactory.buildWhenArgumentsTypeNotMatched, a NPE is thrown because the value of the class cannot be determined. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jan 17, 2025
…1486) See #1477 This is a regression introduced in #1464 When the value is null, the extractor throws a failure. Then, in ErrorMessageFactory.buildWhenArgumentsTypeNotMatched, a NPE is thrown because the value of the class cannot be determined. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Jan 17, 2025
…clipse-vertx#1486) See eclipse-vertx#1477 This is a regression introduced in eclipse-vertx#1464 When the value is null, the extractor throws a failure. Then, in ErrorMessageFactory.buildWhenArgumentsTypeNotMatched, a NPE is thrown because the value of the class cannot be determined. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jan 17, 2025
…1486) (#1487) See #1477 This is a regression introduced in #1464 When the value is null, the extractor throws a failure. Then, in ErrorMessageFactory.buildWhenArgumentsTypeNotMatched, a NPE is thrown because the value of the class cannot be determined. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463
With this change, a DataType always has a param extractor. The default extractor signals the failure to convert to PgParamDesc.