Avoid un-necessary byte copies when decoding a Vert.x Buffer to a protobuf object and perform more optimal allocation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tobuf object and perform more optimal allocation. Motivation: The current implementation of the bridge uses a plain ByteArrayInputStream and then let protobuf parse the message. It turns out there is a KnownLength interface used by the parser to know the actual buffer size to be decoded and optimize the decoding process. In addition we can use Netty ByteBufInputStream to avoid using ByteArrayInputStream and un-necessary copies. Changes: Swap usage of ByteArrayInputStream with a class that extends ByteBufInputStream and implement KnownLength.
|
@franz1981 ping |
franz1981
reviewed
Mar 5, 2025
| @@ -29,15 +33,31 @@ public BridgeMessageDecoder(MethodDescriptor.Marshaller<T> marshaller, Decompres | |||
| this.decompressor = decompressor; | |||
| } | |||
|
|
|||
| private static class KnownLengthStream extends ByteBufInputStream implements KnownLength { | |||
| public KnownLengthStream(Buffer buffer) { | |||
| super(((BufferImpl)buffer).getByteBuf(), buffer.length()); | |||
There was a problem hiding this comment.
the buffer is doesn't have any weird requirement re release ref cnt?
There was a problem hiding this comment.
it does create a slice but closing the ByteBufInputStream releases it
Casting this b/c of the method going away in Buffer interface in Vert.x5 ? |
this method is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current implementation of the bridge uses a plain
ByteArrayInputStreamand then let protobuf parse the message. It turns out there is aKnownLengthinterface used by the parser to know the actual buffer size to be decoded and optimize the decoding process.In addition we can use Netty
ByteBufInputStreamto avoid usingByteArrayInputStreamand un-necessary copies.Changes:
Swap usage of
ByteArrayInputStreamwith a class that extendsByteBufInputStreamand implement KnownLength.