Generator improvements #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
generator-improvements
branch
from
f0ff6e5 to
7572820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few structural improvements.
Annotated client
Client generated code annotated with
VertxGenso it can be used with RxJava or MutinyClass naming simplification
VertxABCGrpcClient→ABCClientVertxABCGrpcServer→ABCServiceScoped service method constants
JSON and transcoded service method constants are now scoped in an enclosing class :
GreeterService.Hello_JSON→GreeterService.Json.HelloNew binder
A binder replaces the
bind_XXXmethods:service.bind_Hello(server)→service.bind(GreeterService.Hello).to(server)Javadoc
Basic javadoc is now generated
Cosmetic
Generated code is properly indented and spaces for more clarity.