Execute SSLHelper.validate as blocking #4441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Jul 21, 2022
vietj
reviewed
Jul 21, 2022
|
I think the use of |
MikeEdgar
commented
Jul 21, 2022
|
@vietj, I'm curious to get your thinking on these changes. I realize there needs to be a certain amount of caution with changes to these classes/methods. |
|
it looks good overall but there are a few things that need to be addressed |
Thanks, let me know what's needed when you have an opportunity. No rush from my perspective. |
|
I will actually reuse this in an general improvement of the SSLHelper because there are other SSLHelper related work that should be done. |
|
@MikeEdgar please have a look at #4468 |
|
yes, I'll credit you in the orignal issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Proposed to fix #4439