Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust Test Agent #23

Merged
merged 13 commits into from
May 15, 2024
Merged

Add Rust Test Agent #23

merged 13 commits into from
May 15, 2024

Commits on Apr 12, 2024

  1. Add Rust Test Agent

    * Add changes to TCK to support Rust Test Agent for Register_and_Send and register_and_unregister
    
    Co-Authored-By: sagarsshah <157176449+sagarsshah@users.noreply.github.com>
    matthewd0123 and sagarsshah committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    eb0531e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Review Comments from Pete

    Sagar and I have taken in the comments from Pete's PR review and addressed most of them in this commit. Mainly:
    * Refactored utils.rs
    * Removed extension trait for utransport
    * Aligned names to rust coding standard
    * Ran rustfmt on all files
    * Ran clippy on all files: we addressed most of the clippy issues, but some will require more intense refactoring
    * Minor fixes and idiomatic cleanup
    
    Co-Authored-By: sagarsshah <157176449+sagarsshah@users.noreply.github.com>
    matthewd0123 and sagarsshah committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    832396e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05c7823 View commit details
    Browse the repository at this point in the history
  3. Remove rust folder

    Need to remove duplicate code that is no longer used.
    matthewd0123 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d380974 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a3cef51 View commit details
    Browse the repository at this point in the history
  5. Librarify utransport_socket

    Aligning the utransport_socket with recommendations from Pete. Instead of importing the utransport_socket.rs, we are now making it into a library crate.
    matthewd0123 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    62f4fc8 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Resolve more comments

    We went through the large majority of issues presented in the PR Review, including:
    * removing almost all expects and unwraps
    * changing many method names to match standards
    * reduce size of many methods through simplification and reorganization
    
    Notes for reviewer:
    * One 'expect' remains [main.rs, line 71]. would appreciate advice on how to remove that
    * One clippy error remains. It's regarding holding the socket across async calls.
    * A few unwraps remain, but those are mostly handled except for one regarding commstatus
    
    Co-Authored-By: sagarsshah <157176449+sagarsshah@users.noreply.github.com>
    matthewd0123 and sagarsshah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    67bc751 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    e78503f View commit details
    Browse the repository at this point in the history
  2. Update for comments, add rust to spawn

    Fix last clippy issue related to holding mutex across awaits (testagent.rs, line 225--)
    Remove last expect for commstatus
    Change wrapperu_message var name to wrapper_umessage
    Add rust to new spawning paradigm in tck_step_implementations.py
    matthewd0123 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d20bcca View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Few Comment resolutions

    * Change dbg! to using log debug! crate.
    * Changed "loop" in test agent to "while"
    * Remove some comments
    matthewd0123 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    82f8d38 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Changes based on review

    * update licenses
    * remove get_ustatus_code
    * add err_string to reuse error msgs
    * change signature of parse_uauthority
    * remove commented code
    * formatting on lib.rs
    * remove panic references since doesn't panic
    
    Co-Authored-By: Pete LeVasseur <11622119+plevasseur@users.noreply.github.com>
    matthewd0123 and PLeVasseur committed May 13, 2024
    Configuration menu
    Copy the full SHA
    02e09c9 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Few more comments

    * Change specialfields to default
    * Add "not implemented" to notification type
    * Some fixes to debug msgs and comments
    matthewd0123 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8c8762a View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Remove initialization of special_fields

    * Remove special_fields from the uattributes deserializer
    matthewd0123 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cb89638 View commit details
    Browse the repository at this point in the history