Align tck tests to requirements #107
Conversation
agosh01
force-pushed
the
aline_tck_tests_to_requirments
branch
3 times, most recently
from
f1d8482
to
7cf0ee2
Compare
stevenhartley
changed the title
agosh01
force-pushed
the
aline_tck_tests_to_requirments
branch
2 times, most recently
from
05251ef
to
3cd501b
Compare
agosh01
force-pushed
the
aline_tck_tests_to_requirments
branch
from
3cd501b
to
45389ec
Compare
| @when('sets to entity URI of "{ue}" with updated "{sub_key}" to "{sub_val}"') | ||
| def set_to_ue_uri(context: Context, ue: str, sub_key: str, sub_val: str): | ||
| ue_number = ue.replace("uE", "") | ||
| context.json_dict.update(context.ue_tracker[int(ue_number) - 1][2]) |
There was a problem hiding this comment.
Index 2 is the transport URI
context.ue_tracker.append(
(
test_agent_name,
context.config.userdata[f"transport{str(counter)}"],
current_uri,
False,
)
)
There was a problem hiding this comment.
This is a dict which keep ue information. We need to know what transport URI are assigned to each uE so we can update uri for L1 and L2 api calls.
The way this dict is setup index 2 is where uri assigned to uE resides
This function pulls that uri and updated key value provided by the feature file
| @given('sets to entity URI of "{ue}" with updated "{sub_key}" to "{sub_val}"') | ||
| @when('sets to entity URI of "{ue}" with updated "{sub_key}" to "{sub_val}"') | ||
| def set_to_ue_uri(context: Context, ue: str, sub_key: str, sub_val: str): | ||
| ue_number = ue.replace("uE", "") |
There was a problem hiding this comment.
no uE as feature file input to this string variable is uE1. I just need 1.
|
Also @agosh01 you need to test if spoofing the source address will generate an error per the update I made in the up-l1/README.adoc |
It will not as CPP implementation won't check for it. Have that been added to java or python ? I make another task to add test for spoofing or you would like that to be covered in this PR ? |
@stevenhartley - Those changes are after the alpha.3 tag in up-spec. I thought we were using the alpha.3 spec for alpha.4 code. Is that incorrect? It would be hard for us to accommodate changes in the spec this close to alpha.4, but once an alpha.4 spec is tagged we could easily implement those changes in the alpha.5 code. |
Update up-tck L1 and L2 test cases to aline with 1.6.0 requirements
Original test cases were creating transport with default URI but then using entirely different source URI for API call i.e. spoofing which is no no spec wise.
In parallel with this up-spec will be updated to provide clarity