Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging init #64

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Logging init #64

wants to merge 4 commits into from

Conversation

olitha
Copy link

@olitha olitha commented Feb 11, 2025

Closes #63

@PLeVasseur
Copy link
Contributor

Hi @olitha -- could you please see this section of our contribution guidelines? We'll need to have you sign the Eclipse Contributor Agreement (ECA) before we can accept contributions.

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @olitha -- thanks for the contribution!

As I mentioned in my comment here we'll need to also have env_logger initialized for example-streamer-implementations and up-linux-streamer-plugin

For the latter, I think you'll want to use env_logger in the fashion it was setup in ustreamer.rs as this was taken from how the Eclipse Zenoh plugin example documentation.

Also note the other comment I left about needing to sign the Eclipse Contributor Agreement (ECA) to be able to accept contributions.

@@ -39,3 +39,16 @@ pub use integration_test_messages::{
request_from_remote_client_for_local_client, response_from_local_client_for_remote_client,
response_from_remote_client_for_local_client,
};

/// Helper method for integration tests to initialise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was mentioning over here, because we need to initialize the env_logger for other cases, you may be able to generalize this or expose this so that the example streamers can use it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging should be initialized in binary and not in lib
2 participants