Use custom UMessage struct #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build.rs script no longer pulls in the umessage.proto from up-spec. Instead, the umessage module no defines the UMessage struct with private fields so that UMessages can now only be created (correctly) via the UMessageBuilder.
PLeVasseur
reviewed
May 28, 2024
| impl UMessage { | ||
| pub fn attributes(&self) -> &UAttributes { |
There was a problem hiding this comment.
I really like this!
So the idea is that we have now not generated the code for the UMessage .proto object, so we can force correctness, as the only way to build a UMessage is via UMessageBuilder and we've made the struct fields private and can only grab the UAttributes and payload Bytes as reference.
Slick!!
There was a problem hiding this comment.
That would have been the idea, yes. Sadly, though, UMessage is actually being used by uTwin in its input/output messages, so the initial approach will not work ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build.rs script no longer pulls in the umessage.proto from up-spec.
Instead, the umessage module no defines the UMessage struct with
private fields so that UMessages can now only be created (correctly) via
the UMessageBuilder.