Fix [DS] Validation of transitive generated 'osgi.extender=osgi.component' requirement fails #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
laeubi
force-pushed
the
pr-3832-ds-missing-cap
branch
from
02da10a
to
215c64b
Compare
laeubi
force-pushed
the
pr-3832-ds-missing-cap
branch
2 times, most recently
from
d8ea9ae
to
ec590ad
Compare
laeubi
force-pushed
the
pr-3832-ds-missing-cap
branch
2 times, most recently
from
5f1d631
to
f99d3cc
Compare
Add a minimal reproducer test-case for issue eclipse-tycho#3824 regarding the validation failure of transitive generated 'osgi.extender=osgi.component' requirements in bundles containing DS components of version 1.4.
Currently Tycho always uses the INITIAL dependency metadata to compute the preliminary target platform. As this metadata can change once the project is packed (e.g. headers added / removed) this can lead to problems in plugins that depend on the changed plugin because P2 sees the updated metadata afterwards and fails. This now distinguish both cases and used the SEED metadata if the project was already packed. Fix eclipse-tycho#3824
laeubi
force-pushed
the
pr-3832-ds-missing-cap
branch
from
f99d3cc
to
b913061
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
1 similar comment
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Tycho always uses the
INITIALdependency metadata to computethe preliminary target platform. As this metadata can change once the
project is packed (e.g. headers added / removed) this can lead to
problems in plugins that depend on the changed plugin because P2 sees
the updated metadata afterwards and fails.
This now distinguish both cases and used the
SEEDmetadata if theproject was already packed.
Fix #3824