Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tycho-4.0.x] Move DependencyArtifacts computation into project types #3186

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 8, 2023

Backport

This will backport the following commits from master to tycho-4.0.x:

Questions ?

Please refer to the Backport tool documentation

Currently DefaultTychoResolver computes the DependencyArtifacts on
behalf of the TychoProject and then set these into the project using a
context value, this has several drawbacks, e.g as it introduce ordering
problem and we need to handle some things special for custom types.

Instead the TychoProject itself should compute the dependencies on
demand as its concrete implementation knows best how to compute these
items and can simply do so on first request.

(cherry picked from commit 05bdf27)
@laeubi laeubi merged commit 5274aac into tycho-4.0.x Dec 8, 2023
2 checks passed
@akurtakov akurtakov deleted the backport/tycho-4.0.x/pr-3182 branch December 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant