Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tycho-4] Adapt to P2 enhancements in Eclipse 2023-12 #3125

Conversation

HannesWell
Copy link
Member

Back-port of #3043, that also reverts the temporary changes of PublishProductToolImpl made in #2929, which are obsolete now that the new P2 version has support for names of update-sites built in.

Copy link

github-actions bot commented Dec 5, 2023

Test Results

384 files  ±0  384 suites  ±0   2h 56m 1s ⏱️ + 24m 11s
378 tests ±0  372 ✔️ ±0    6 💤 ±0  0 ±0 
756 runs  ±0  743 ✔️ ±0  13 💤 ±0  0 ±0 

Results for commit ae36610. ± Comparison against base commit cd3d5f0.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member

laeubi commented Dec 6, 2023

@HannesWell some test fail now :-\

@HannesWell
Copy link
Member Author

@HannesWell some test fail now :-\

Looks like this is a consequence of eclipse-equinox/p2#310, but tycho still uses pack.gz repositories:
https://github.com/eclipse-tycho/tycho/tree/master/tycho-core/src/test/resources/repositories/packgz

So good news is, it is not a bug, the bad news the tests have to be rewritten...

This also reverts the temporary changes of PublishProductToolImpl made
in eclipse-tycho#2929, which are obsolete
now that the new P2 version has support for names of update-sites built
in.
@HannesWell HannesWell force-pushed the tycho-4.0.x-adapt-to-p2-2023-12 branch from 109ccc5 to ae36610 Compare December 9, 2023 19:58
@HannesWell HannesWell merged commit 90b690a into eclipse-tycho:tycho-4.0.x Dec 9, 2023
7 of 8 checks passed
@HannesWell HannesWell deleted the tycho-4.0.x-adapt-to-p2-2023-12 branch December 9, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants