Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a caching P2 transport #797

Closed
laeubi opened this issue Mar 23, 2022 · 5 comments
Closed

Implement a caching P2 transport #797

laeubi opened this issue Mar 23, 2022 · 5 comments
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Mar 23, 2022

Currently certain access to files (mostly p2.index) are not cached making tycho quite slow. Another issue are non-existing index files if p2 tries to query to find out where the meta-data resides.

laeubi added a commit to laeubi/tycho that referenced this issue Mar 23, 2022
…enStream()

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi added a commit to laeubi/tycho that referenced this issue Mar 23, 2022
…enStream()

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi added a commit to laeubi/tycho that referenced this issue Mar 26, 2022
laeubi added a commit that referenced this issue Mar 28, 2022
@laeubi
Copy link
Member Author

laeubi commented Mar 29, 2022

It seems this has increased the buildtime of the unit test a lot, I'll take a look if this is just because of now we have cold-caches or if there are other issues, probably we need to disable the transport by default (currently enabled) until it is clear what causing this, lets wait for the next build ...

Build no. 315 was 1h 7min
Build no. 316 was 2h 35min

I triggered a new master build to se the results... Interestingly the PR run was completed in normal time, maybe network issues?

@laeubi
Copy link
Member Author

laeubi commented Mar 29, 2022

Build times are back to normal

@laeubi laeubi closed this as completed Mar 29, 2022
@laeubi
Copy link
Member Author

laeubi commented Mar 29, 2022

@jcompagner do you like to try it out? https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#improved-p2-transport-for-more-efficiently-http-cache-handling-and-improved-offline-mode

If you set -Dtycho.p2.transport.min-cache-minutes=40320 Tycho should only contact update-site servers once a month, so if your targets are really static this should improve build times and save you from server outages.

@jcompagner
Copy link
Contributor

jcompagner commented Mar 29, 2022

i will have a look (but busy in the comming 2 weeks with our own release, then i am back on master where this kind of stuff is in)
i guess i need then the nighly build right (to get 3.0)
what if i don't set that -Dtycho.p2.transport.min-cache-minutes=40320 ? what is the default value? (EDIT: 1 hour is see, and its kind of an extra cache if the server doesn't provide nice caching)

@laeubi
Copy link
Member Author

laeubi commented Mar 29, 2022

default is one hour.

@laeubi laeubi added this to the 3.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants