Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildPropertiesParser should use reactor project instead of basedir do the work #557

Closed
laeubi opened this issue Jan 23, 2022 · 0 comments
Closed
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Jan 23, 2022

BuildPropertiesParser uses a rather strange approach of taking a basedir and then using the basedir to find the maven project via the maven session.
The callers of BuildPropertiesParser already have a project and call basedir on the project...

Beside this, this requires the LegacySupport component to obtain the session of the current thread what makes it problematic if code runs in background threads or if we ant to make Tycho a core extension see #556

The proposal is to simply pass the project around instead of the basedir.

laeubi added a commit to laeubi/tycho that referenced this issue Jan 23, 2022
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi added a commit to laeubi/tycho that referenced this issue Jan 23, 2022
@laeubi laeubi closed this as completed in f220185 Jan 24, 2022
@laeubi laeubi added this to the 2.7 milestone Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant