-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use regular Maven coordinates -when possible- for dependencies #443
Comments
It's closely related to eclipse-dash/dash-licenses#125 and this might fix the dash-licenses bug even. |
One hotspot would be |
Just one thing that came into my mind, given we have a repository of type p2 specified, it should be possible to even resolve |
Some incremental work can be done to ease implementation of this feature:
|
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Recover maven nature of an artifact by inspecting its attached IU Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Recover maven nature of an artifact by inspecting its attached IU Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
…in dependency:list
dependency:list
Currently, running
mvn dependency:list
for a Tycho module lists all dependencies under the formp2-installable-unit:org.domain.pluginId:version
(egp2-installable-unit:org.mockito.mockito-core:4.1.0
). The scope is usuallysystem
and the absolute path to file is set.In case where the dependency is known to have Maven coordinates, it would be better to reuse the coordinates of this dependency to showcase it's the "official" artifact from Maven repo. So in case of Mockito, it would become
org.mockito:mockito-core:4.1.0
. p2 metadata are expected to contain the necessary info to map a p2 artifact/unit back to the Maven coordinates they're generated from, those data should then be used inP2ResolverImpl
when callingresult.addArtifact
to not hardcode usage ofArtifactType.TYPE_INSTALLABLE_UNIT
and let Maven coordinates be used in place.I expect that as long as the scope remains system and path is hardcoded, this shouldn't be too disruptive.
The text was updated successfully, but these errors were encountered: