Skip to content

Commit

Permalink
Fix #463 - Computing target platform for MavenProject is missleading
Browse files Browse the repository at this point in the history
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
  • Loading branch information
laeubi committed Jan 4, 2022
1 parent 75f3e51 commit 7c496b3
Showing 1 changed file with 11 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,22 +120,27 @@ public void resolveProject(MavenSession session, MavenProject project, List<Reac
}

DependencyResolver resolver = dependencyResolverLocator.lookupDependencyResolver(project);

logger.info("Computing target platform for " + project);
String threadMarker;
if (logger.isDebugEnabled()) {
threadMarker = "[" + Thread.currentThread().getName().replaceAll("^ForkJoinPool-(\\d+)-", "") + "] ";
} else {
threadMarker = "";
}
logger.debug(threadMarker + "Computing preliminary target platform for " + project);
TargetPlatform preliminaryTargetPlatform = resolver.computePreliminaryTargetPlatform(session, project,
reactorProjects);

logger.info(threadMarker + "Resolving dependencies of " + project);
ReactorProject reactorProject = DefaultReactorProject.adapt(project);
TargetPlatformConfiguration configuration = TychoProjectUtils.getTargetPlatformConfiguration(reactorProject);

DependencyResolverConfiguration resolverConfiguration = configuration.getDependencyResolverConfiguration();

logger.info("Resolving dependencies of " + project);
DependencyArtifacts dependencyArtifacts = resolver.resolveDependencies(session, project,
preliminaryTargetPlatform, reactorProjects, resolverConfiguration);

if (logger.isDebugEnabled() && DebugUtils.isDebugEnabled(session, project)) {
StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(threadMarker);
sb.append("Resolved target platform for ").append(project).append("\n");
dependencyArtifacts.toDebugString(sb, " ");
logger.debug(sb.toString());
Expand All @@ -149,7 +154,7 @@ public void resolveProject(MavenSession session, MavenProject project, List<Reac
List<ArtifactKey> testDependencies = ((BundleProject) tychoProjectType)
.getExtraTestRequirements(reactorProject);
if (!testDependencies.isEmpty()) {
logger.info("Resolving test dependencies of " + project);
logger.info(threadMarker + "Resolving test dependencies of " + project);
DependencyResolverConfiguration testResolverConfiguration = new DependencyResolverConfiguration() {
@Override
public OptionalResolutionAction getOptionalResolutionAction() {
Expand All @@ -173,7 +178,7 @@ public List<ArtifactKey> getExtraRequirements() {
resolver.injectDependenciesIntoMavenModel(project, dr, dependencyArtifacts, testDependencyArtifacts, logger);

if (logger.isDebugEnabled() && DebugUtils.isDebugEnabled(session, project)) {
StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(threadMarker);
sb.append("Injected dependencies for ").append(project.toString()).append("\n");
for (Dependency dependency : project.getDependencies()) {
sb.append(" ").append(dependency.toString());
Expand Down

0 comments on commit 7c496b3

Please sign in to comment.