-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(encryptionKey): align credential and wallet config #201
Conversation
8a45c3e
to
53f4ef6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be the other way around as the wallet encryption key must match the credential encryption key: I mean shouldn't the credential encryption key in the issuer service remain as that is the key which does and will continue doing encrypting?
53f4ef6
to
8ec628e
Compare
absolutely right. adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter issue
charts/ssi-credential-issuer/values.yaml
Error: 62:52 [trailing-spaces] trailing spaces
Description
Align the credential and wallet configuration to use the same encryption key
Why
The same key is used for encrypting and decryption the wallet data by different processes.
Issue
Refs: #197
Checklist