Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 Bug - Credential Approval Email - missing wallet details #215

Closed
jjeroch opened this issue Jun 21, 2024 · 4 comments
Closed

2.0.0 Bug - Credential Approval Email - missing wallet details #215

jjeroch opened this issue Jun 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Jun 21, 2024

Version
2.0.0

Issue
The verified_credential_approved.html email template does not populate the "wallet" value as expected. (see screenshot below)

image

Expected Result

  • Wallet Info getting displayed
  • Credential Version getting displayed on top of the credential type
@jjeroch jjeroch added the bug Something isn't working label Jun 21, 2024
@jjeroch
Copy link
Contributor Author

jjeroch commented Jun 21, 2024

@Phil91 please move the call to the correct repo if it must be placed in issuer component or somewhere else. Not sure where the issue is sitting

@Phil91
Copy link
Member

Phil91 commented Jun 24, 2024

@jjeroch short question regarding the content of the wallet field. not a 100% sure what's expected there. When approving the request we don't have the wallet information, since it is handled within the following process. Previously the field was filled with the name of the company, which we don't have anymore. We could in theory display the bpn instead.

@jjeroch
Copy link
Contributor Author

jjeroch commented Jun 30, 2024

@Phil91 lets have a sync about this, we need to check again who actually submits / sends the email to the customer. If its the portal, we should have the necessary information such as the company name or BPNL - but lets sync on it shortly

@Phil91
Copy link
Member

Phil91 commented Jul 24, 2024

instead of the wallet we will send the tenant name.

@Phil91 Phil91 transferred this issue from eclipse-tractusx/portal-backend Jul 24, 2024
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Jul 24, 2024
Phil91 added a commit that referenced this issue Jul 24, 2024
Phil91 added a commit that referenced this issue Jul 25, 2024
Phil91 added a commit that referenced this issue Jul 25, 2024
Refs: #215
Reviewed-By: Evelyn Gurschler <evelyn.gurschler@bmw.de>
@Phil91 Phil91 moved this from IN PROGRESS to IN REVIEW in Portal Jul 31, 2024
@github-project-automation github-project-automation bot moved this from IN REVIEW to USER READY in Portal Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants