Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encryptionKey): align credential and wallet config #201

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 15, 2024

Description

Align the credential and wallet configuration to use the same encryption key

Why

The same key is used for encrypting and decryption the wallet data by different processes.

Issue

Refs: #197

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from evegufy July 15, 2024 14:04
@Phil91 Phil91 force-pushed the bugfix/197-encryption-key branch from 8a45c3e to 53f4ef6 Compare July 16, 2024 05:40
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be the other way around as the wallet encryption key must match the credential encryption key: I mean shouldn't the credential encryption key in the issuer service remain as that is the key which does and will continue doing encrypting?

@evegufy evegufy requested a review from ntruchsess July 16, 2024 10:53
@Phil91 Phil91 force-pushed the bugfix/197-encryption-key branch from 53f4ef6 to 8ec628e Compare July 16, 2024 11:24
@Phil91
Copy link
Member Author

Phil91 commented Jul 16, 2024

shouldn't it be the other way around as the wallet encryption key must match the credential encryption key: I mean shouldn't the credential encryption key in the issuer service remain as that is the key which does and will continue doing encrypting?

absolutely right. adjusted.

@Phil91 Phil91 requested a review from evegufy July 16, 2024 11:25
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter issue

charts/ssi-credential-issuer/values.yaml
Error: 62:52 [trailing-spaces] trailing spaces

@ntruchsess ntruchsess requested a review from evegufy July 16, 2024 12:34
@Phil91 Phil91 merged commit 1e1ca59 into release/v1.1.0-rc.1 Jul 16, 2024
5 checks passed
@Phil91 Phil91 deleted the bugfix/197-encryption-key branch July 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants