Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): adjust status query param for subscription-status #969

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 3, 2024

Description

  • added query param name to endpoint GET: /api/apps/subscribed/subscription-status to filter for app names
  • added query param name to endpoint GET: /api/services/subscribed/subscription-status to filter for service names
  • changed query param statusId to status of endpoint GET: /api/apps/subscribed/subscription-status

Why

To be able to search for specific apps

Issue

Refs: #592

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 changed the base branch from main to release/v2.2.0-RC4 September 3, 2024 12:56
@Phil91 Phil91 requested review from ntruchsess and evegufy September 3, 2024 12:56
@Phil91 Phil91 added this to the Release 2.2.0 milestone Sep 3, 2024
@MaximilianHauer MaximilianHauer added the priority PR needs to prioritized at review label Sep 6, 2024
@evegufy
Copy link
Contributor

evegufy commented Sep 9, 2024

@MaximilianHauer @Phil91 is the milestone 24.12 correct for #592?

@Phil91 Phil91 force-pushed the bugfix/592-app-status branch from 3e983be to 27ef6d8 Compare September 9, 2024 13:34
@Phil91
Copy link
Member Author

Phil91 commented Sep 9, 2024

@MaximilianHauer @Phil91 is the milestone 24.12 correct for #592?

@evegufy in my opinion it isn't

@Phil91 Phil91 requested a review from evegufy September 9, 2024 13:35
Copy link

@ntruchsess ntruchsess merged commit 321f678 into release/v2.2.0-RC4 Sep 10, 2024
11 checks passed
@ntruchsess ntruchsess deleted the bugfix/592-app-status branch September 10, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants