Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(technicalUser): adjust deletion process #956

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix(technicalUser): adjust deletion process #956

merged 2 commits into from
Aug 29, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 27, 2024 •
edited
Loading

Description

  • adjust deletion for external technical user
  • adjust state of deleted users

Why

Currently the deletion process of async users has some issues and a deletion of pending users isn't possible

Issue

Refs: #949 #950 #809 #952

Corresponding Assets PR

eclipse-tractusx/portal-assets#393

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from ntruchsess and evegufy August 27, 2024 11:31
@Phil91 Phil91 mentioned this pull request Aug 27, 2024
Merged
9 tasks
@Phil91 Phil91 modified the milestones: Release 24.12, Release 2.2.0 Aug 27, 2024
@MaximilianHauer MaximilianHauer added the priority PR needs to prioritized at review label Aug 29, 2024
@Phil91 Phil91 requested a review from oyo August 29, 2024 11:23
Phil91 added 2 commits August 29, 2024 13:26
@Phil91
fix(technicalUser): adjust deletion process
dab75e5 
* adjust deletion for external technical user
* adjust state of deleted users

Refs: #949 #950 #809
@Phil91
feat(sa): adjust delete technical user logic
f142193 
Refs: #950
@Phil91 Phil91 force-pushed the bugfix/950-delete-technical-user branch from d6cac4d to f142193 Compare August 29, 2024 11:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit c67221c into release/v2.2.0-RC3 Aug 29, 2024
11 checks passed
@Phil91 Phil91 deleted the bugfix/950-delete-technical-user branch August 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
priority PR needs to prioritized at review
Projects
Portal
Status: USER READY
Milestone
Release 2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @oyo @MaximilianHauer