fix(DID): removed authentication details from logs DIM response #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now i have removed the secrets from the logs but i think we can utilize the |
Phil91
force-pushed
the
release/v2.2.0-RC3
branch
from
b2e8059 to
bcb8125
Compare
dhiren-singh-007
force-pushed
the
bugfix/remove-secret-from-logs
branch
from
f3ffb22 to
56e4675
Compare
dhiren-singh-007
force-pushed
the
bugfix/remove-secret-from-logs
branch
from
2fddd0b to
7591945
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/administration/Administration.Service/BusinessLogic/RegistrationBusinessLogic.cs
Fixed
Show fixed
Hide fixed
|
Phil91
approved these changes
Aug 27, 2024
Phil91
pushed a commit
that referenced
this pull request
Aug 28, 2024
Reviewed-By: Phil Schneider <info@philschneider.de>
dhiren-singh-007
added a commit
to dhiren-singh-007/portal-backend
that referenced
this pull request
Aug 28, 2024
…pse-tractusx#951) Reviewed-By: Phil Schneider <info@philschneider.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the authentication details from logs DIM response and only logged the DIM document
Why
It was exposing the client id and secret of Dim wallet
Issue
NA
Checklist
Please delete options that are not relevant.