Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sd-trigger): adjust retrigger process for sd creation #938

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 16, 2024

Description

adjust the retrigger process for sd documents, when re triggering the sd creation for companies, a process is created for each company without a self description document that is active.
When re triggering the sd creation for connectors, a process is created for each connector without a self description document that is active.

Why

Currently their only is one process for all companies or connectors in place which makes the error handling harder

Issue

Refs: #813

Corresponding CD PR

eclipse-tractusx/portal#419

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the bugfix/813-sd-retrigger branch from 64fb41a to 22375dd Compare August 16, 2024 06:57
@Phil91 Phil91 force-pushed the bugfix/813-sd-retrigger branch 2 times, most recently from 74ae806 to 95b2f9c Compare August 16, 2024 08:56
@Phil91 Phil91 requested review from ntruchsess and evegufy August 16, 2024 09:13
@Phil91 Phil91 added this to the Release 2.2.0 milestone Aug 28, 2024
@Phil91 Phil91 added the priority PR needs to prioritized at review label Aug 29, 2024
@Phil91 Phil91 force-pushed the bugfix/813-sd-retrigger branch from 95b2f9c to 63949f9 Compare August 29, 2024 06:52
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Phil91 Phil91 merged commit 69c0c09 into release/v2.2.0-RC3 Aug 29, 2024
12 of 13 checks passed
@Phil91 Phil91 deleted the bugfix/813-sd-retrigger branch August 29, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants