Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registration): new attribute type added in registration application endpoint #900

Conversation

AnuragNagpure
Copy link
Contributor

Description

Enhance the /api/administration/registration/applications?size=10&page=0 endpoint by adding a new attribute "type" to the response, which indicates whether the application is "external" or "internal". This information is available at the application level in the database.

Why

Retrieve the "type" information from the application-level data in the database.
Ensure the "type" attribute is properly mapped and included in the endpoint response.
Update the existing response structure to include the new "type" attribute for each application in the "content" array.

Issue

#842

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link

sonarqubecloud bot commented Aug 6, 2024

@AnuragNagpure AnuragNagpure requested review from Phil91 and ntruchsess and removed request for Phil91 August 6, 2024 05:41
@Phil91 Phil91 merged commit 4ff4a7e into eclipse-tractusx:main Aug 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants