Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clearinghouse): add comments to process step and application checklist #847

Merged
merged 5 commits into from
Aug 7, 2024
Merged

feat(clearinghouse): add comments to process step and application checklist #847

merged 5 commits into from
Aug 7, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 18, 2024 •
edited
Loading

Description

  • enhance application checklist with a comment of the skipped self description step
  • adjust selfDescription retriever to check if clearinghouseConnect is disabled

Why

To give the user an overview why the step was skipped

Issue

Refs: #837

Corresponding CD PR

eclipse-tractusx/portal#400

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 marked this pull request as ready for review July 18, 2024 13:29
evegufy
evegufy reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to main branch, milestone was already adjusted

@Phil91 Phil91 force-pushed the feature/837-clearinghouse branch from 94de1eb to fa92c16 Compare July 26, 2024 09:02
@Phil91 Phil91 changed the base branch from release/v2.1.0-RC2 to main July 26, 2024 09:04
@Phil91
Copy link
Member Author

Phil91 commented Jul 26, 2024

Please change to main branch, milestone was already adjusted

rebase to main done.

@Phil91 Phil91 requested a review from evegufy July 26, 2024 09:06
evegufy
evegufy previously approved these changes Aug 5, 2024
View reviewed changes
@evegufy
Copy link
Contributor

evegufy commented Aug 5, 2024

@Phil91 I noticed that a conflict needs to get resolved

@Phil91 Phil91 force-pushed the feature/837-clearinghouse branch from fa92c16 to c173961 Compare August 6, 2024 07:52
@Phil91
Copy link
Member Author

Phil91 commented Aug 6, 2024

@Phil91 I noticed that a conflict needs to get resolved

@evegufy conflict is resolved :)

@Phil91 Phil91 requested review from evegufy and ntruchsess August 6, 2024 08:44
@Phil91 Phil91 added the priority PR needs to prioritized at review label Aug 6, 2024
@Phil91 Phil91 mentioned this pull request Aug 6, 2024
Merged
4 tasks
@Phil91 Phil91 force-pushed the feature/837-clearinghouse branch from 83a5bf6 to 125577b Compare August 6, 2024 13:18
@Phil91
feat(clearinghouse): add comments to process step and application che…
9f35954 
…cklist

enhance application checklist with a comment of the skipped self description step

Refs: #837
@Phil91 Phil91 force-pushed the feature/837-clearinghouse branch 3 times, most recently from 4dcd766 to dbb0317 Compare August 6, 2024 14:05
@Phil91 Phil91 force-pushed the feature/837-clearinghouse branch from dbb0317 to 34dc57e Compare August 6, 2024 14:05
@ntruchsess ntruchsess self-assigned this Aug 6, 2024
@Phil91 Phil91 requested a review from evegufy August 6, 2024 15:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit 4dea66d into main Aug 7, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/837-clearinghouse branch August 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees

@ntruchsess ntruchsess

Labels
priority PR needs to prioritized at review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @evegufy @ntruchsess