feat(certificate): enhance company certificate db attributes and API details #823
Conversation
AnuragNagpure
changed the title
AnuragNagpure
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| Id = id; | ||
| ValidFrom = validFrom; | ||
| CompanyCertificateTypeId = companyCertificateTypeId; | ||
| CompanyCertificateStatusId = companyCertificateStatusId; | ||
| CompanyId = companyId; | ||
| DocumentId = documentId; | ||
| CompaniesCertificateAssignedSites = new HashSet<CompaniesCertificateAssignedSite>(); |
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor Warning
There was a problem hiding this comment.
Hi @AnuragNagpure could you please solve the codeql finding and clarify the milestone of the #574 with @jjeroch , currently still set to our already released 2.0.0 version ...
AnuragNagpure
force-pushed
the
feature/574-certificate-management-db-enhancement
branch
from
92dd83e to
50b09db
Compare
…e with changes in respective endpoints is done
ntruchsess
force-pushed
the
feature/574-certificate-management-db-enhancement
branch
3 times, most recently
from
658d548 to
0c75148
Compare
src/portalbackend/PortalBackend.PortalEntities/Entities/CompanyCertificate.cs
Dismissed
Show resolved
Hide resolved
ntruchsess
force-pushed
the
feature/574-certificate-management-db-enhancement
branch
from
0c75148 to
e3d24de
Compare
ntruchsess
force-pushed
the
feature/574-certificate-management-db-enhancement
branch
from
e3d24de to
6ba71d3
Compare
I dismissed the codeql-finding as false positive (see comment) |
Hi @ntruchsess its milestone is set as 24.12 |
There was a problem hiding this comment.
@AnuragNagpure @jjeroch : in the ticket #574 the validator field is specified as 'The validator is given by the company ID'. Please clarify whether the column in database and the corresponding field in the endpoint's payload should be GUID or string (the PR currently implements string but this seems to be in conflict with the ticket).
Other than that the PR is fine. I did adjust the entities names (Companies -> Company) as the specified names were in conflict with existing naming conventions. (I also left a comment in the ticket about this). You need to pull my changes before applying further commits
Hi @ntruchsess as per my discussion with @jjeroch it should be string only currently we will get this field as null. In future there will be use of validator, We only have to add it in Get Endpoint response. |
…details (#823) * additional attributes added * migration files with updated attributes added * implementation of additional added fields in company certificate table with changes in respective endpoints is done * tests: adjust unit tests for companyCertificates * Changes for BPNS implementation with updated test cases added * update version for framework.model Refs: #574 --------- Co-authored-by: Phil Schneider <info@philschneider.de> Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Description
Need to add additional parameters in company_certificate(externalcertificatenumber, sites, validfrom, validtill, issuer, validator) table along with additional table companies_certificate_assigned_sites to link mutiple sites(BPNS) with comapanycertificate id.
After changes in db need to change Post and get endpoints as mentioned below:
POST: api/administration/companydata/companyCertificate
GET /api/administration/companydata/companyCertificates
GET: api/administration/companydata/businessPartnerNumber}/companyCertificates
Also validation added parameters also need to implement.
Why
For tracking multiple BPNS against companies this implementation is required.
Issue
#574
Checklist
Please delete options that are not relevant.